Skip to content

fix: ignore frontmatter examples in fenced code blocks - #84

Merged
Iktahana merged 1 commit into
mainfrom
hotfix/fenced-frontmatter
Sep 4, 2026
Merged

Iktahana merged 1 commit into
mainfrom
hotfix/fenced-frontmatter

Conversation

@Iktahana

@Iktahana Iktahana commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

Summary:

  • make the late-frontmatter guard track CommonMark backtick and tilde fences
  • require matching fence characters and sufficient closing-fence length
  • keep genuine late frontmatter outside code fences on the literal recovery path
  • cover the production docs shape plus indentation and invalid-fence edge cases

Root cause:
The guard around markdown-rs scanned raw delimiter lines without tracking fenced code blocks. MDI/YAML examples in the Full syntax reference were therefore mistaken for a second frontmatter block, causing the entire page to use literal fallback.

Local verification:

  • cargo fmt --check
  • cargo clippy with warnings denied
  • cargo test: 77 unit tests plus all integration and doc tests pass; environment-dependent native Chromium smoke excluded after it failed to launch locally
  • pnpm docs:build: 467 pages
  • generated syntax reference contains rendered strong and link elements, with no literal prerequisite Markdown

remarkMdi and Rust-backed documentation parsing remain enabled.

@codecov

codecov Bot commented Sep 4, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 98.86364% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
mdi-core/src/lib.rs 98.86% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

@Iktahana
Iktahana merged commit 4195ec5 into main Sep 4, 2026
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant