Potential fix for code scanning alert no. 1: Clear-text logging of sensitive information#55
Closed
ilyabrin wants to merge 1 commit into
Closed
Potential fix for code scanning alert no. 1: Clear-text logging of sensitive information#55ilyabrin wants to merge 1 commit into
ilyabrin wants to merge 1 commit into
Conversation
…nsitive information Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/ilyabrin/disk/security/code-scanning/1
To fix the problem, we need to ensure that sensitive information in HTTP headers is always obfuscated or omitted before being logged. Specifically, in the
LogRequestmethod, we should always log the sanitized value for each header, never the original value. If a value is sanitized (i.e., replaced with asterisks or masked), we log the sanitized value; otherwise, we log the original value only if it is not sensitive. The misleading logic that logs[sanitized]when the value is not sanitized should be corrected. Additionally, we should review the initial request line to ensure it does not include sensitive information (though method and URL are generally safe). The changes are limited to theLogRequestmethod inlogger.go.Required changes:
LogRequestto always log the sanitized value, never the original.[sanitized]log line.Suggested fixes powered by Copilot Autofix. Review carefully before merging.