feat(music): add smart window focus to music popup source link#90
Open
brendancohan wants to merge 1 commit into
Open
feat(music): add smart window focus to music popup source link#90brendancohan wants to merge 1 commit into
brendancohan wants to merge 1 commit into
Conversation
Contributor
|
This looks good. @ilyamiro can we get this merged into baseline? |
Owner
|
Yes, in a few hours |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Many widgets like this are useful for myself and other like me because the audio source is usually left running on another workspace in the background for some time working. Having a quick link in these widgets to focus the audio source has always been a great simple convenience feature for me.
Added a MouseArea link from the "VIA - Source" text that links to the app window source of the audio. hpyrctl and jq will search and match the music data and switch focus to that workspace and window. To allow a clean exit of the QML, switched to Quickshell.execDetached as well.