fix(frontend): ensure shimmer loading animation renders during analysis (#700)#1024
Open
Pcmhacker-piro wants to merge 2 commits into
Open
fix(frontend): ensure shimmer loading animation renders during analysis (#700)#1024Pcmhacker-piro wants to merge 2 commits into
Pcmhacker-piro wants to merge 2 commits into
Conversation
added 2 commits
June 12, 2026 00:55
…is fetch Before the fetch starts, showShimmers() is called but the browser may not get a paint cycle before the API responds and renderResults() overwrites the shimmer DOM. Add await requestAnimationFrame(...) after showShimmers() to guarantee the browser paints the shimmer placeholder before the fetch begins. This ensures the loading animation is visible even for fast API responses, fixing the UX gap where the results panel stayed blank during analysis. Fixes imDarshanGK#700
|
👋 This PR has had no activity for 7 days. Please push updates or comment if you still need more time. Inactive PRs may be closed automatically after 7 more days. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
showShimmers()function and.shimmer-cardCSS were already defined in the frontend, but the browser never got a paint cycle to display them before the API fetch completed andrenderResults()replaced the shimmer DOM.Fix
Add
await new Promise(r => requestAnimationFrame(r))aftershowShimmers()indoAnalyze(). This forces the browser to paint the shimmer loading state before the fetch begins, ensuring users see feedback even when the API responds quickly.Changes
frontend/index.html:3394— Added one-lineawait requestAnimationFrame(...)aftershowShimmers()call to guarantee the shimmer paints before the fetch starts. Applies to both ZIP and regular code analysis flows.Testing
Fixes #700