feat: add literal identity comparison bug pattern for Python#1034
Open
VasuNagar11 wants to merge 3 commits into
Open
feat: add literal identity comparison bug pattern for Python#1034VasuNagar11 wants to merge 3 commits into
VasuNagar11 wants to merge 3 commits into
Conversation
imDarshanGK
requested changes
Jun 16, 2026
imDarshanGK
left a comment
Owner
There was a problem hiding this comment.
terminal output alone is not enough. Please add a UI/demo flow (video or screenshots) so the feature behavior can be clearly verified.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR implements a static analysis rule to flag instances where string or integer literals are compared using identity operators (
is/is not) instead of value equality operators (==/!=). Using identity operators on primitive types checks object memory reference identity rather than value equality, which introduces unpredictable runtime evaluation bugs because Python caches small integers and short strings arbitrarily.Related Issue
Fixes #820
Type of change
Checklist
mainpytest -vand all tests passfeat/fix/docs/test: short descriptionScreenshots (if frontend change)
N/A (Backend logic addition)
Test evidence