fix(subscription): add weekly digest subscribe feedback and fix base URL#1061
Open
NayansiDupare wants to merge 1 commit into
Open
fix(subscription): add weekly digest subscribe feedback and fix base URL#1061NayansiDupare wants to merge 1 commit into
NayansiDupare wants to merge 1 commit into
Conversation
imDarshanGK
requested changes
Jun 19, 2026
imDarshanGK
left a comment
Owner
There was a problem hiding this comment.
Please add a short video demo showing the weekly digest subscribe flow with success/error feedback and base URL fix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves the lack of visual feedback when subscribing to the Weekly Digest in the footer and fixes the Mixed Content / incorrect API base URL routing on the live site. Also addresses a lifespan console startup crash on Windows.
Related Issue
Closes #1058
Changes
getApiBase()infrontend/index.htmlto resolve towindow.location.originwhen running on a web server instead of hardcodinglocalhost:8000.digestFeedbackcontainer in the footer with success/error/loading visual cues (custom SVG icons, text colors matching design tokens) and toasts.inputlistener to dynamically clear feedback once the user edits the email field.…inbackend/app/main.pylifespan print/logging statements to preventUnicodeEncodeErrorcrashes on Windows CP1252 consoles.Base.metadata.create_all(bind=engine)at startup lifespan to build SQLAlchemy ORM tables (likedigest_subscriptions) for clean setups.frontend/tests/helpers.jsandfrontend/tests/e2e/analyze.spec.jsto ES module syntax to match thetests/package.jsonconfiguration.How to Test
uvicorn app.main:app --reloadhttp://localhost:8000/app/)