feat: add throttling and backpressure to background job processing (#…#1096
Open
Bhavy12-cell wants to merge 1 commit into
Open
feat: add throttling and backpressure to background job processing (#…#1096Bhavy12-cell wants to merge 1 commit into
Bhavy12-cell wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #632
Problem
The weekly digest scheduler sent emails to all subscribers in a simple
sequential loop with no concurrency control. Under volume spikes this
would overwhelm the email provider and database connection pool.
Solution
New File —
backend/app/services/job_throttle.pyImplements three components:
JobThrottle — semaphore-based concurrency limiter with:
max_concurrent_workerscap via threading.Semaphoremin_interval_secondsbetween job startsthe interval is multiplied by
backoff_multipliermax_queue_sizeis exceeded so callers can shed load explicitly
ThrottleConfig — dataclass with tuneable defaults:
throttled_batch() — helper that processes any iterable with
a ThreadPoolExecutor bounded by the throttle config
Modified File —
backend/app/services/scheduler.pythrottled_batch()(prevents cross-thread session sharing bugs)
New File —
backend/tests/test_job_throttle.py9 tests covering:
Environment Variables (tunable without code change)
DIGEST_MAX_WORKERSDIGEST_MAX_QUEUEDIGEST_MIN_INTERVAL_SDIGEST_ERROR_THRESHOLDDIGEST_BACKOFF_MULTIPLIERFiles Changed
backend/app/services/job_throttle.py— new throttling modulebackend/app/services/scheduler.py— updated to use throttled_batchbackend/tests/test_job_throttle.py— full test coverage