fix: add allowlist to sanitize_language_hint#789
Open
diaxx1309 wants to merge 10 commits into
Open
Conversation
previously any stringwas accepted as a language hint with no validation. Adds an allowlist of supported language and return a 422 error for invalid values.
Owner
|
@diaxx1309 ci failing |
fix: add allowlist validation to sanitize_language_hint
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
previously any string was accepted as a language hint with no validation. Adds an allowlist of supported language and return a 422 error for invalid values.
Description
Added an allowlist of supported languages to 'sanitize_language_hint()' in 'sanitize.py'. Previously, any string was accepted as a language hint with no validation. This restricts input to known supported languages and returns a 422 error for invalid values.
Related Issue
Fixes #469
Type of change
Checklist
mainpytest -vand all tests passfeat/fix/docs/test: short descriptionScreenshots (if frontend change)
Test evidence
pytest -v # paste output