Fix rail-mode carousel bugs and gate Slick assets by engine#24
Merged
Conversation
view.js crashed on rail carousels (JSON.parse on a missing data-slick attribute), aborting Slick init for any other carousel on the page. The homepage pattern's rail carousel also carried stale Slick data-* attributes that save() no longer renders, which would trigger a block validation error in the editor. Slick assets are now skipped entirely on pages where every carousel block uses the rail engine, instead of loading whenever any carousel block is merely present. Bump to 2.21.0.
✅ WordPress Plugin Check Report
📊 ReportAll checks passed! No errors or warnings found. 🤖 Generated by WordPress Plugin Check Action • Learn more about Plugin Check |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #23, which shipped the rail engine but left the fixes below unmerged.
slick.min.js,slick-theme.css) on the selected engine, so rail-mode carousels no longer load jQuery/Slick at all.Verified on
http://demo.imagewize.test/aviendha/with the homepage pattern re-imported: the client rail renders as a scroll-snap rail andslick-slideris absent from the markup.