Remove broken browser automation from notion service#74
Merged
Conversation
The Playwright-based login flow for Notion's internal integration page was broken; remove the NotionServiceSession entirely so the service has no automated login. Update the info string to direct agents to the notion-mcp service unless valid credentials are already set, since users can still configure credentials manually. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Collaborator
|
@qi-imbue Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NotionServiceSessionfrom thenotionservice since the internal-integration login flow is broken. The service now has nogetSession, so the rest of the codebase treats it as having no automated login.notion'sinfostring to direct agents to usenotion-mcpunless valid credentials are already set fornotion(credentials can still be set manually by the user).notion-mcpservice is untouched.Test plan
npx tsc --noEmitpassesnpx vitest runpasses (515 tests, including service registry, lint, typecheck)latchkey auth set notion -H "Authorization: Bearer <token>"still works and thatlatchkeyno longer offers a browser login fornotion🤖 Generated with Claude Code