Add configuration to disable batch-requeuing #221
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Add a new bool field on OffloadConfig (default true) that will gate the scheduler's on-pop re-queue policy. Default-true preserves the current behavior; this commit only introduces the field and updates all OffloadConfig struct literals across the source tree and tests. Includes TOML parse tests covering the default and explicit-set cases. Refs: code-vsml Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Thread the new OffloadConfig flag through Scheduler::new and extract the inline re-queue logic from pop() into a single &self method enqueue_followups. The method is a no-op when the flag is false, so batches run exactly once. Default-true preserves the prior hedging behavior (multi-test halving and singleton retry-counter). The new method takes &self because the Scheduler is shared across workers via Arc and uses interior mutability via Mutex/Notify; no mutation requires &mut self. All existing call sites pass true to preserve behavior. Adds a test exercising the false branch for both multi-test and singleton batches. Refs: code-vsml Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We added batch-requeuing to hegde against long-running tests and to help stuck batches by splitting and resubmitting them.
This feature may not be desired by everyone, so this MR allows disabling of this feature.