Skip to content

fix: Axios error logs include response body #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lukehesluke wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: Axios error logs include response body #7

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion src/logger.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ function axiosErrorConfigToLoggableObject(error) {
};
if (_.isString(error.config.data)) {
// this can be ridiculously long so truncate it
returnError.axiosConfig.data = truncateString(64, error.config.data);
returnError.axiosConfig.data = truncateString(256, error.config.data);
}
return returnError;
}
Expand All @@ -40,6 +40,12 @@ function axiosErrorConfigToLoggableObject(error) {
*/
function errorToLoggableObject(error) {
const returnError = { ...error };
/* Without this, axios errors contain very limited information, as they have a .toJSON() function, which outputs
just things like error.stack and misses things like error.response.data. CircularJSON, which is our formatter for
logs, seems to use this `toJSON` function if it's there */
if (typeof returnError.toJSON === 'function') {
delete returnError.toJSON;
}
if (error instanceof Error) {
// JS errors lose these attributes when converted to objects (lord knows why)
returnError.name = error.name;
Expand Down