Skip to content

Retry downloads in case of failure #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sionescu wants to merge 2 commits into from
+5 −1
Closed

Retry downloads in case of failure #16

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d86f6f8
Retry downloads in case of failure
sionescu Nov 20, 2025
2dd30f5
Update action.yml
imjasonh Nov 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,11 @@ runs:
echo "Installing crane @ ${tag} for ${os} on ${arch}"
tmp=$(mktemp -d)
cd ${tmp}
curl -fsL https://github.com/google/go-containerregistry/releases/download/${tag}/go-containerregistry_${os}_${arch}.tar.gz | tar xz ${out}
url=https://github.com/google/go-containerregistry/releases/download/${tag}/go-containerregistry_${os}_${arch}.tar.gz
curl -fsL \
--remove-on-error --retry 10 --retry-max-time 120 \
-o out.tar.gz ${url} || exit 1
Comment on lines +55 to +56

Copilot AI Nov 22, 2025

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The --remove-on-error flag is not available in older versions of curl (it was added in curl 7.83.0, released in April 2022). Consider verifying that the GitHub Actions runners have a compatible curl version, or provide a fallback mechanism. Alternatively, you could manually remove the file on error: curl -fsL --retry 10 --retry-max-time 120 -o out.tar.gz ${url} || { rm -f out.tar.gz; exit 1; }

Suggested change
--remove-on-error --retry 10 --retry-max-time 120 \
-o out.tar.gz ${url} || exit 1
--retry 10 --retry-max-time 120 \
-o out.tar.gz ${url} || { rm -f out.tar.gz; exit 1; }

Copilot uses AI. Check for mistakes.
tar xz -f out.tar.gz ${out}

Copilot AI Nov 22, 2025

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tar command syntax is incorrect. The correct syntax for GNU tar is tar xzf out.tar.gz ${out} (no space between flags and argument) or tar -xzf out.tar.gz ${out} (with hyphens). The current syntax tar xz -f out.tar.gz ${out} will not work correctly because xz is treated as separate options and then -f is a separate option.

Suggested change
tar xz -f out.tar.gz ${out}
tar xzf out.tar.gz ${out}

Copilot uses AI. Check for mistakes.
chmod +x ${tmp}/${out}
PATH=${PATH}:${tmp}
echo "${tmp}" >> $GITHUB_PATH
Expand Down
Loading