Feature/sources show on click#1933
Draft
danieleguido wants to merge 8 commits intodevelopfrom
Draft
Conversation
Show a minimal tooltip when hovering dates with no data by rendering the year and a 0 content-items message. Add an idx property to TooltipPosition and the tooltip state to track vertical position, return idx from getDataValuesAtPosition, and propagate it in emitTooltipEvent. Also adjust formatting of translation calls for readability.
Replace a console.log in SourcesOverviewDateValueItem.vue with an 'itemClick' emit and forward item clicks to the timeline. In SourcesOverviewTimeline.vue add container click handling and an on-data-item click handler that compute visual coordinates, reuse the tooltip payload shape, and emit a new 'tooltipClick' event. Also add the corresponding emit signature and helper emitClickEvent. Wire up the new 'tooltipClick' handler in SourcesOverviewPage.vue to log the click payload. These changes unify click + hover interactions and expose click events with the same interaction payload as tooltipMove for consumers.
…t leaving the page
Move the pointerdown listener onto the draggable handle and update styles so the grab/grabbing cursor and hover/active feedback apply only to the handle. Fix prop usage in SourceOverviewNavigator to reference props.* (including tooltipPosition) and remove an unused destructure. Emit a 'tooltipOut' event on container click in SourcesOverviewTimeline. Wire up selectionMonitorStore in SourcesOverviewPage and show the selected item when a tooltip is clicked (also add more informative console logging). These changes improve UX and ensure correct prop/state flow for tooltip and selection handling.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.