Open
Conversation
Member
|
Thanks for the PR, @mjankowski! The changes look good to me. But yeah, that http-cookie issue is rough. I'm subscribed to that issue and will give it a few days to see if there's movement before making any additional changes here. |
jgarber623
approved these changes
Apr 11, 2026
Member
jgarber623
left a comment
jgarber623
left a comment
There was a problem hiding this comment.
Approved changes but holding for a few days to see if there's any resolution to sparklemotion/http-cookie#62.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think these should both pass.
Separately, I think this issue from
http-cookiedep sparklemotion/http-cookie#62 winds up impactingWebmentionwhen it runs on latest ... presumably they will sort that out soon.