Skip to content

Fix unreliable floating point equality (RUF069) #350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
inducer merged 2 commits into from
Feb 13, 2026
+28 −2
Merged

Fix unreliable floating point equality (RUF069) #350

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fb45e9f
fix: unreliable floating point equality (RUF069)
alexfikl Feb 13, 2026
0136b8f
chore: update baseline
alexfikl Feb 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 26 additions & 0 deletions .basedpyright/baseline.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9106,6 +9106,32 @@
}
}
],
"./arraycontext/impl/pytato/outline.py": [
{
"code": "reportReturnType",
"range": {
"startColumn": 11,
"endColumn": 39,
"lineCount": 1
}
},
{
"code": "reportUnknownVariableType",
"range": {
"startColumn": 15,
"endColumn": 45,
"lineCount": 1
}
},
{
"code": "reportUnknownArgumentType",
"range": {
"startColumn": 29,
"endColumn": 44,
"lineCount": 1
}
}
],
"./arraycontext/loopy.py": [
{
"code": "reportUnknownMemberType",
Expand Down
4 changes: 2 additions & 2 deletions test/test_arraycontext.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -311,12 +311,12 @@ def test_array_context_np_like(

if sym_name == "zeros_like":
if np.isscalar(result):
assert result == 0.0
assert result == 0.0 # noqa: RUF069
else:
assert actx.to_numpy(actx.np.all(actx.np.equal(result, 0.0)))
elif sym_name == "ones_like":
if np.isscalar(result):
assert result == 1.0
assert result == 1.0 # noqa: RUF069
else:
assert actx.to_numpy(actx.np.all(actx.np.equal(result, 1.0)))
else:
Expand Down
Loading