Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR improves type information in boxtree by adding explicit ClassVar/generic typing annotations to better support static type checking without changing runtime behavior.
Changes:
- Annotate
box_flags_enumconstants and metadata asClassVarfields. - Make
dataclass_array_containerpreserve the decorated class type viaTypeVargenerics.
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
boxtree/tree.py |
Adds ClassVar annotations to box flag constants/metadata to improve typing clarity. |
boxtree/array_context.py |
Updates dataclass_array_container to be generically typed (type[T] -> type[T]). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
inducer
force-pushed
the
2026-02-typing
branch
from
299ebb2 to
efbd96c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.