Check dipoles are available before using it#93
Open
gaohao95 wants to merge 1 commit intoinducer:mainfrom
Open
Conversation
inducer
force-pushed
the
dist-pytential
branch
from
0bc3d24 to
c269cad
Compare
inducer
reviewed
Aug 26, 2024
| self.use_dipoles = dipole_vec is not None | ||
| if self.use_dipoles: | ||
| assert dipole_vec.shape == (self.dim, self.tree.nsources) | ||
| if not hasattr(self, "use_dipoles"): |
Owner
There was a problem hiding this comment.
Add a comment on how we could possibly get here with use_dipoles already set.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR checks the dipoles are available before using it. This is to support distributed implementation in potential: inducer/pytential#224.