Functions by inducer · Pull Request #364 · inducer/pytato

inducer · 2022-10-14T23:15:56Z

cc @kaushikcfd

This is a draft because:

Contains commits from Implement WalkMapperWithExtraArgs #387

pytato/tracing.py

kaushikcfd · 2022-11-09T06:38:17Z

This is ready! And can be reviewed after we merge #387.

pytato/function.py

kaushikcfd · 2023-03-14T20:14:12Z

@inducer: This is ready to land, IMO.

Co-authored-by: Andreas Kloeckner <andreask@illinois.edu>

inducer

I'm still missing transform.calls, but I figured I would submit this to see how you feel about these comments.

pytato/function.py

pytato/analysis/__init__.py

pytato/equality.py

pytato/visualization.py

pytato/transform/__init__.py

inducer

Here are a few more review comments for transform.calls, which I've started on.

But it occurred to me that this is sufficiently unwieldy that it's probably best to split this into "everything else" and the transforms for merge.

inducer · 2023-05-17T20:47:13Z

pytato/transform/calls.py

+    def combine(self, *args: FrozenSet[CallSiteLocation]
+                ) -> FrozenSet[CallSiteLocation]:
+        from functools import reduce
+        return reduce(lambda a, b: a | b, args, frozenset())


Suggested change

return reduce(lambda a, b: a | b, args, frozenset())

return reduce(operator.or_, frozenset())

inducer · 2023-05-17T20:51:25Z

pytato/transform/calls.py

+        :class:`CallSiteLocation`\ s being built. Must be altered (by creating
+        a new instance of the mapper) before entering the function body of a
+        new :class:`~pytato.function.Call`.


Suggested change

:class:`CallSiteLocation`\ s being built. Must be altered (by creating

a new instance of the mapper) before entering the function body of a

new :class:`~pytato.function.Call`.

:class:`CallSiteLocation`\ s being built.

(Only of interest to implementers of subclasses, quite apparent from code. Plus I disagree with the phrasing "altered".)

inducer · 2023-05-17T20:58:46Z

pytato/transform/calls.py

+            self.replacement_map,  # type: ignore[attr-defined]
+            self.current_stack + (expr,),  # type: ignore[attr-defined]
+            self.stack_to_replace_on,  # type: ignore[attr-defined]


Why not just declare the types in the class body? (That is, IIUC this correctly.)

inducer · 2023-05-17T21:08:30Z

pytato/transform/calls.py

+                 stack_to_replace_on: Tuple[Call, ...]) -> None:
+        self.replacement_map = replacement_map
+        self.current_stack = current_stack
+        self.stack_to_replace_on = stack_to_replace_on


It looks like this is done one stack at a time. Is that the most efficient approach? (vs. batching)

inducer · 2023-05-17T21:18:09Z

pytato/transform/calls.py

+            return super().map_named_call_result(expr)
+
+
+def _have_same_axis_length(arrays: Collection[Array],


What (if not an error) should this return if the collection is empty?

inducer · 2023-05-17T21:18:24Z

pytato/transform/calls.py

+               for other_ary in arrays)
+
+
+def _have_same_axis_length_except(arrays: Collection[Array],


What (if not an error) should this return if the collection is empty?

inducer · 2023-05-17T21:26:09Z

It looks like 12f7524 ("Add regressions pt.inline_calls") contains a bit more than the commit message lets on.

inducer · 2023-05-18T18:49:53Z

Superseded by #436 and #437. I've untangled the unrelated aspects of 12f7524 in the rebase that led to those.

kaushikcfd mentioned this pull request Oct 16, 2022

Use ~~dataclasses~~ attrs for pt.Array #365

Merged

inducer mentioned this pull request Oct 17, 2022

[loopy-codegen, bug] Code generation for tagged NamedArrays is buggy #195

Open

inducer commented Oct 17, 2022

View reviewed changes

pytato/tracing.py Outdated Show resolved Hide resolved

pytato/tracing.py Outdated Show resolved Hide resolved

pytato/tracing.py Outdated Show resolved Hide resolved

pytato/tracing.py Outdated Show resolved Hide resolved

pytato/tracing.py Outdated Show resolved Hide resolved

kaushikcfd force-pushed the functions branch 3 times, most recently from 7846ab7 to 3b226ae Compare October 18, 2022 06:06

kaushikcfd mentioned this pull request Oct 19, 2022

Make AbstractResultWithNamedArrays taggable #368

Merged

kaushikcfd force-pushed the functions branch 2 times, most recently from e060c67 to edb1b19 Compare October 19, 2022 23:10

kaushikcfd force-pushed the functions branch 5 times, most recently from 36ca60a to 7378490 Compare November 5, 2022 06:32

kaushikcfd mentioned this pull request Nov 5, 2022

Minor bug fixes #381

Merged

kaushikcfd force-pushed the functions branch 12 times, most recently from 66e173d to 88bed5c Compare November 9, 2022 06:37

kaushikcfd force-pushed the functions branch from 88bed5c to e290435 Compare November 9, 2022 21:14

kaushikcfd marked this pull request as ready for review November 9, 2022 21:14

kaushikcfd force-pushed the functions branch 6 times, most recently from 6a81131 to 4f2deaa Compare March 8, 2023 20:47

kaushikcfd reviewed Mar 13, 2023

View reviewed changes

pytato/function.py Show resolved Hide resolved

kaushikcfd force-pushed the functions branch 2 times, most recently from 50b0c68 to 10a909b Compare March 14, 2023 17:23

kaushikcfd mentioned this pull request Mar 14, 2023

Add a pass to outline computations in a function inducer/arraycontext#221

Merged

3 tasks

kaushikcfd force-pushed the functions branch from dc9fd0e to 8c529af Compare March 14, 2023 20:07

kaushikcfd force-pushed the functions branch from 8c529af to eea9c02 Compare March 14, 2023 22:25

kaushikcfd force-pushed the functions branch 2 times, most recently from c39d7d3 to a0ae9c7 Compare April 10, 2023 20:14

kaushikcfd and others added 7 commits April 19, 2023 11:18

Introduce pt.trace_call

d5fbb61

Co-authored-by: Andreas Kloeckner <andreask@illinois.edu>

Support mapper methods for FunctionDefintion, Call

965d740

Co-authored-by: Andreas Kloeckner <andreask@illinois.edu>

Implement pt.inline_calls

d58b7d3

Add pt.tracing module to docs

bda2471

Add regressions pt.inline_calls

12f7524

Add regressions for pt.concatenate_calls

040cc9e

Add pt.analysis.get_num_call_sites

f6e64a2

inducer force-pushed the functions branch from a0ae9c7 to f6e64a2 Compare April 19, 2023 16:18

inducer commented Apr 21, 2023

View reviewed changes

inducer commented May 17, 2023

View reviewed changes

This was referenced May 18, 2023

Functions #436

Merged

"Concatenate calls" transformation #437

Closed

inducer closed this May 18, 2023

	return reduce(lambda a, b: a \| b, args, frozenset())
	return reduce(operator.or_, frozenset())

		return super().map_named_call_result(expr)


		def _have_same_axis_length(arrays: Collection[Array],

		for other_ary in arrays)


		def _have_same_axis_length_except(arrays: Collection[Array],

Conversation

inducer commented Oct 14, 2022 • edited by kaushikcfd Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

kaushikcfd commented Nov 9, 2022

Uh oh!

Uh oh!

kaushikcfd commented Mar 14, 2023

Uh oh!

inducer left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

inducer left a comment

Choose a reason for hiding this comment

Uh oh!

inducer May 17, 2023

Choose a reason for hiding this comment

Uh oh!

inducer May 17, 2023

Choose a reason for hiding this comment

Uh oh!

inducer May 17, 2023

Choose a reason for hiding this comment

Uh oh!

inducer May 17, 2023

Choose a reason for hiding this comment

Uh oh!

inducer May 17, 2023

Choose a reason for hiding this comment

Uh oh!

inducer May 17, 2023

Choose a reason for hiding this comment

Uh oh!

inducer commented May 17, 2023

Uh oh!

inducer commented May 18, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

inducer commented Oct 14, 2022 •

edited by kaushikcfd

Loading