test(veltro): align campaign readiness checks - #549
Conversation
|
Heads-up on merging this one, and it is my doing rather than yours. This branch predates #560, which stopped tracking compiled bytecode. It has a Git leaves the file sitting in the working tree, so resolving with git rm <path>.disOr just rebase onto current master, where the file no longer exists and the Nothing else in the PR is affected — for d in appl appl/mpeg appl/veltro tests; do (cd $d && mk install); done
Sorry for the friction — five open PRs are in this position because of the |
|
Reads correctly. Three of the four changes are straightforwardly right:
The provisioning change is the interesting one, and it is a strengthening: One thing to fix in the description rather than the code: the verification list ./tools/verify-dis-build.shwhich builds the tree and checks it against Also needs the |
Two conflicts, both from master moving under the branch. dis/tests/tools9p_test.dis: master deleted it in #560, which stopped tracking compiled bytecode. Resolved by taking the deletion — dis/ is a build product now and the file is regenerated by for d in appl appl/mpeg appl/veltro tests; do (cd $d && mk install); done tests/host/tools9p_integration_test.sh: positional, not semantic. This branch adds provision_valid_subset and master added provision_probe_compile_run (INFR-434) at the same point in the file. They are independent tests, so both are kept, in that order. Verified after resolution: the branch's diff against master is exactly its own four files, the runtime tree builds and matches the manifest, and all three host scripts pass bash -n.
Summary
/dis/testspath/tool/pathsfile as readableVerification
tests/host/task_provisioning_test.shtests/host/tools9p_basics_test.shtests/host/tools9p_integration_test.sh(40 passed)tests/host/grind_escape_test.shtools/verify-dis-paths.shNo runtime or campaign configuration changes.