Fix Windows CI: Use vcpkg manifest mode#18
Merged
infinityabundance merged 4 commits intomainfrom Feb 3, 2026
Merged
Conversation
- Update vcpkg to more recent commit (01f602195983451bc83e72f4214af2cbc495aa94) - Use runVcpkgInstall: true to leverage vcpkg.json manifest - Remove separate install step (now handled by manifest mode) - Add build verification step to diagnose output path issues - Update artifact paths to handle both Release/Debug subdirs Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Windows GitHub runners have vcpkg pre-installed at C:\vcpkg. Using this instead of cloning from scratch is more reliable and faster. - Remove lukka/run-vcpkg action in favor of pre-installed vcpkg - Use explicit vcpkg.exe install command with triplet - Add caching for installed packages - Fix PowerShell path separators Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
In manifest mode (when vcpkg.json exists), vcpkg install should be run without individual package arguments - it reads from vcpkg.json instead. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
MSVC doesn't understand GCC's __attribute__((packed)) syntax. Add PACKED_STRUCT and PACKED_STRUCT_END macros that use: - __pragma(pack(push, 1)) / __pragma(pack(pop)) for MSVC - __attribute__((packed)) for GCC/Clang Fixes Windows build errors in packet_header_t, control_packet_t, and input_event_pkt_t struct definitions. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
vcpkg.jsonChanges
01f602195983451bc83e72f4214af2cbc495aa94(more recent)runVcpkgInstall: trueto use manifest modevcpkg installstep (dependencies now fromvcpkg.json)Test plan
🤖 Generated with Claude Code