fix(predicate): adds exclusive method to get user notification data#498
Merged
pedroanastacio merged 4 commits intostagingfrom Mar 13, 2026
Merged
Conversation
guimroque
reviewed
Mar 6, 2026
guimroque
reviewed
Mar 6, 2026
guimroque
reviewed
Mar 6, 2026
guimroque
reviewed
Mar 6, 2026
Member
guimroque
left a comment
There was a problem hiding this comment.
Code Review
Summary
This PR successfully addresses a security vulnerability by preventing exposure of user email addresses in the predicate endpoint. The refactoring moves notification logic to a dedicated service and introduces a new method to safely retrieve user notification data.
Strengths
- Excellent security fix removing email exposure from public endpoint
- Clean separation of concerns moving notification logic to NotificationService
- Proper error handling with structured logging
- Good use of parallel processing for notifications and emails
Issues
- 1 critical, 1 important, 1 suggestion
GabrielTozatti
approved these changes
Mar 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The endpoint
GET - /predicate/:predicateIdwas returning more information than it should have, in this case the user's email address. To obtain notification information about a user, an internal method must be created in the API so as not to expose critical information.}Summary
getNotificationInfomethod to obtain user notification information.GET - /predicate/:predicateId.Checklist