Add .ionapi file loader for JavaWebClientOAuth2 sample - #22
Open
piyush15102003 wants to merge 1 commit into
Open
piyush15102003 wants to merge 1 commit into
piyush15102003 wants to merge 1 commit into
Conversation
Closes infor-cloud#13: OAuth2ClientConfig previously required client id/secret/endpoints to be hardcoded as source constants or entries in ifsceoauth.properties - error prone, and puts credentials in source code, per the issue. Adds IonApiFileLoader/IonApiCredentials to parse the standard .ionapi JSON credentials file Infor issues per tenant (ti, cn, ci, cs, iu, pu, saak, sask) and populate OAuth2ClientConfig from it, deriving the authorization/token/ revocation endpoints from `pu` using this sample's existing endpoint-suffix convention. Wired into OAuth2ClientConfig.InitProperties() via an opt-in IONAPI_FILE_PATH system property/env var, falling back to the existing properties-file behavior when unset so nothing breaks for current users.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #13