Skip to content

[FIX] stock_batch_picking_voucher: asignar números de remitos antes de imprimir#929

Open
mav-adhoc wants to merge 1 commit into
ingadhoc:19.0from
adhoc-dev:19.0-t-67613-mav
Open

[FIX] stock_batch_picking_voucher: asignar números de remitos antes de imprimir#929
mav-adhoc wants to merge 1 commit into
ingadhoc:19.0from
adhoc-dev:19.0-t-67613-mav

Conversation

@mav-adhoc
Copy link
Copy Markdown
Contributor

Summary

  • Se corrige el flujo en do_print_and_assign del modelo stock.picking.batch: antes, cuando el talonario no era autoprinted (numeración por sistema), el número de remito se asignaba después de generar el PDF (via el controlador HTTP), por lo que la primera impresión salía sin número.
  • Ahora el número se asigna antes de imprimir, usando estimated_number_of_pages (o 1 si no está definido), de modo que la primera impresión ya contiene el número de remito.

Tarea relacionada

https://www.adhoc.inc/odoo/my-tasks/67613

Test plan

  • Configurar un lote de transferencias con talonario no autoprinted.
  • Hacer click en "Imprimir Remitos" desde un lote en estado done.
  • Verificar que el PDF generado ya incluye el número de remito asignado (primera impresión).
  • Verificar que al re-imprimir, el número no cambia (no se asigna dos veces).

Copilot AI review requested due to automatic review settings May 21, 2026 19:23
@roboadhoc
Copy link
Copy Markdown
Collaborator

Pull request status dashboard

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

This PR adjusts the batch picking voucher printing flow to assign voucher numbers based on an estimated page count, and bumps the module version accordingly.

Changes:

  • Update do_print_and_assign() to compute a pages value and call assign_numbers(pages, book) before printing.
  • Remove the previous branch that skipped number assignment for non-autoprinted books and used a batch context for printing.
  • Bump addon version from 18.0.1.2.0 to 18.0.1.3.0.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
stock_batch_picking_voucher/models/stock_picking_batch.py Changes number assignment + printing control flow to depend on autoprinted and estimated pages.
stock_batch_picking_voucher/manifest.py Version bump reflecting the behavioral change.

Comment on lines +77 to +78
pages = 1 if self.book_id.autoprinted else (self.estimated_number_of_pages or 1)
self.assign_numbers(pages, self.book_id)
self.assign_numbers(1, self.book_id)
pages = 1 if self.book_id.autoprinted else (self.estimated_number_of_pages or 1)
self.assign_numbers(pages, self.book_id)
return self.do_print_batch_vouchers()
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants