Pytests for each step in the workflow and initial GitHub Actions setup.#1
Open
Sasha-Barisic wants to merge 5 commits into
Open
Pytests for each step in the workflow and initial GitHub Actions setup.#1Sasha-Barisic wants to merge 5 commits into
Sasha-Barisic wants to merge 5 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Good morning @pchlap,
Hope you are well!
In this PR:
Discussion
While developing a unit test for the
scan_filefunction in preprocess.py, I tested what happens when a non-DICOM file is provided (even though this is unlikely in practice). I expected the result to be None and the status to be "error", but instead I received result = None, status = "ok", and an error message.I also tried with a random DICOM file from the test data and encountered the same result - the status was "ok" despite an error being raised during scanning.
Looking at the
scan_filefunction, it seems the except block does not explicitly set the status to "error". Was this intentional - perhaps to keep files in quarantine regardless of scan success?I have commented out the affected unit tests for now:
in test_preprocess.py.
Also, no urgency to review - just when you have some time.
Thank you and enjoy your weekend!