Skip to content

fix: uniform observability + RejectInvalidArgs + reconnect on initial connect failure#11

Merged
inhuman merged 2 commits into
mainfrom
011-fixes
May 12, 2026
Merged

fix: uniform observability + RejectInvalidArgs + reconnect on initial connect failure#11
inhuman merged 2 commits into
mainfrom
011-fixes

Conversation

@inhuman
Copy link
Copy Markdown
Owner

@inhuman inhuman commented May 12, 2026

Summary

  • RejectInvalidArgs — new fifth RejectReason constant; fires on invalid args JSON, placeholder bad fields, and schema-validation failures
  • OnRejectedCall, AfterCall, and Metrics.RecordCall now fire consistently on all rejection paths (was asymmetric before)
  • ServerNames() now excludes servers that are currently down
  • Initial connect failure now registers a down stub and starts the reconnect supervisor (previously those servers were silently dropped)

Test plan

  • go test ./... passes with race detector
  • golangci-lint run clean
  • New test TestOnRejectedCall_InvalidArgs covers the new reason

@inhuman inhuman merged commit d31b344 into main May 12, 2026
3 checks passed
@inhuman inhuman deleted the 011-fixes branch May 12, 2026 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant