feat: per-server call timeout (ServerConfig.CallTimeout)#5
Merged
Conversation
Zero or negative value inherits the multiplexer-wide default (WithCallTimeout). Timeout resolution is a single helper effectiveTimeout in caller.go; error messages report the effective value so users can distinguish per-server vs global timeouts. Three integration tests cover the per-server, zero-inherit, and negative-as-zero cases; race detector clean.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ServerConfig.CallTimeout time.Duration— per-server call timeout overrideWithCallTimeout(default 30 s)effectiveTimeout(perServer, global)incaller.goresolves the effective value; timeout error messages report it accuratelyChanges
config.goCallTimeoutfield with godoccaller.goeffectiveTimeouthelper + use inCallTooltimeout_test.godoc.goCHANGELOG.mdTest plan
TestPerServerTimeout_ShortTimeoutFires— per-server 150ms fires, other server with global 10s succeedsTestPerServerTimeout_ZeroInheritsGlobal— zero CallTimeout uses global 50msTestPerServerTimeout_NegativeTreatedAsZero— negative treated as zerogo test -race ./...— full suite greengolangci-lint run ./...— 0 issues