Skip to content

[INJICERT-1274] license compliance issue-- hibernate core#147

Merged
swatigoel merged 1 commit into
inji:developfrom
tw-mosip:INJICERT-1274
Apr 28, 2026
Merged

[INJICERT-1274] license compliance issue-- hibernate core#147
swatigoel merged 1 commit into
inji:developfrom
tw-mosip:INJICERT-1274

Conversation

@jaswanthkumartw

@jaswanthkumartw jaswanthkumartw commented Apr 28, 2026

Copy link
Copy Markdown

Summary by CodeRabbit

  • Chores
    • Updated build dependencies across multiple modules to ensure compatibility and stability.

Signed-off-by: jaswanthkumartw <jaswanthkumar.p@thoughtworks.com>
@coderabbitai

coderabbitai Bot commented Apr 28, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 256c167b-f74a-4f2a-8f7c-98ef57044888

📥 Commits

Reviewing files that changed from the base of the PR and between 4469a8f and b9d6627.

📒 Files selected for processing (4)
  • mock-certify-plugin/pom.xml
  • mosip-identity-certify-plugin/pom.xml
  • postgres-dataprovider-plugin/pom.xml
  • sunbird-rc-certify-integration-impl/pom.xml

Walkthrough

Four Maven modules add the jboss-logging library as a provided-scope dependency, standardizing the logging framework across mock certify, MOSIP identity certify, postgres dataprovider, and Sunbird RC certify integration plugins without bundling it into artifacts.

Changes

Cohort / File(s) Summary
POM Dependency Updates
mock-certify-plugin/pom.xml, mosip-identity-certify-plugin/pom.xml, postgres-dataprovider-plugin/pom.xml, sunbird-rc-certify-integration-impl/pom.xml
Added org.jboss.logging:jboss-logging v3.6.1.Final as provided-scope dependency across all four modules.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Suggested reviewers

  • swatigoel

Poem

🐰 Hop, hop, hooray! The logging flows so bright,
With JBoss in our classpath, all modules unified in sight,
Four plugins now speak in harmony's tone,
Logging standards planted, gracefully grown! 📚✨

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Title check ⚠️ Warning The title references a license compliance issue with Hibernate Core, but the changeset only adds jboss-logging dependencies across four pom.xml files—not Hibernate Core. The title is misleading about the actual content of the changes. Update the title to accurately reflect the change, e.g., '[INJICERT-1274] Add jboss-logging dependency for license compliance' or similar, to match the actual dependency additions in the pull request.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@swatigoel swatigoel merged commit acc390d into inji:develop Apr 28, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants