fix(plugin): #863 Fix IDA VCI plugin configuration

[jaswanthkumartw]

Summary by CodeRabbit

• Chores

  • Consolidated internal helper component architecture and removed deprecated helper classes.
  • Updated configuration property names for helper bean activation.

• Improvements

  • Made signature request payload inclusion configurable instead of using a fixed default value.

[coderabbitai]

Warning

Rate limit exceeded

@jaswanthkumartw has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 20 minutes and 59 seconds before requesting another review.

To keep reviews running without waiting, you can enable usage-based add-on for your organization. This allows additional reviews beyond the hourly cap. Account admins can enable it under billing.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 9861ebe5-7390-4448-81ec-039d383a0a8d

📥 Commits

Reviewing files that changed from the base of the PR and between aaddbf0 and adfa409.

📒 Files selected for processing (1)

• mosip-identity-certify-plugin/src/main/java/io/mosip/certify/mosipid/integration/service/HelperService.java

Walkthrough

The PR refactors Spring bean activation conditions and removes deprecated VCI-specific helper classes. Configuration property names are updated from mosip.certify.integration.data-provider-plugin to mosip.certify.integration.ida-plugin-helper across multiple helper classes. Three deprecated VCI-specific helpers are deleted, and the main service is updated to use unified helper classes instead.

Changes

Cohort / File(s)	Summary
Spring Bean Condition Updates AuthTransactionHelper.java, TransactionHelper.java, HelperService.java	Updated @ConditionalOnProperty annotations from data-provider-plugin=IdaDataProviderPluginImpl to ida-plugin-helper=IdaPluginImpl for consistent bean activation. HelperService also makes includePayload configurable via property instead of hardcoding to true.
Deprecated Classes Removal VCIAuthTransactionHelper.java, VCITransactionHelper.java, VCIHelperService.java	Completely removed three deprecated VCI-specific helper classes (total 181 lines deleted). These were marked for deprecation and replaced by unified helper implementations.
Service Integration Updates IdaVCIssuancePluginImpl.java	Updated dependency injection to use TransactionHelper instead of VCITransactionHelper and HelperService instead of VCIHelperService for obtaining OAuth transactions and request signatures.
Test Updates TransactionHelperTest.java, IdaVCIssuancePluginImplTest.java	Refactored tests to target new helper classes instead of VCI-specific ones. Updated mock dependencies and assertions accordingly while maintaining test behavior.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Possibly related PRs

• [INJICERT-1295] Update mosipid from vcissuance to data provider plugin #130: Modifies the same Spring conditional bean registrations (AuthTransactionHelper, TransactionHelper, HelperService) with @ConditionalOnProperty updates—related changes to the same integration helper code areas.

Suggested reviewers

• swatigoel
• ckm007

Poem

🐰 The VCI helpers hop away,
New unified beans dance and play,
Conditions rebound with cleaner names,
Configuration speaks in simpler frames,
Deprecation's gone—refactored today! ✨

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Title check	✅ Passed	The title 'Fix IDA VCI plugin configuration' directly describes the main change: refactoring the conditional bean activation from data-provider-plugin to ida-plugin-helper configuration properties across multiple helper and service classes.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Review rate limit: 0/1 reviews remaining, refill in 20 minutes and 59 seconds.}

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 3

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Inline comments:
In
`@mosip-identity-certify-plugin/src/main/java/io/mosip/certify/mosipid/integration/helper/TransactionHelper.java`:
- Line 16: The TransactionHelper bean is conditionally activated by
`@ConditionalOnProperty`(value = "mosip.certify.integration.ida-plugin-helper",
havingValue = "IdaPluginImpl") while IdaVCIssuancePluginImpl depends on
TransactionHelper and HelperService and is activated by
mosip.certify.integration.vci-plugin=IdaVCIssuancePluginImpl; align activation
so the helper beans are available when the VCI plugin is enabled by either
changing the TransactionHelper (and related helper bean) `@ConditionalOnProperty`
to check mosip.certify.integration.vci-plugin with havingValue
"IdaVCIssuancePluginImpl" or add the vci-plugin property as an additional
required property on the helper beans (or alternatively add the
ida-plugin-helper condition to IdaVCIssuancePluginImpl) so that
IdaVCIssuancePluginImpl, TransactionHelper, and HelperService are enabled under
the same property set.

In
`@mosip-identity-certify-plugin/src/main/java/io/mosip/certify/mosipid/integration/service/HelperService.java`:
- Around line 44-45: In HelperService.java fix the malformed `@Value` injection
and missing import: add the import for
org.springframework.beans.factory.annotation.Value and change the annotation on
the includePayload field from the invalid
"${{mosip.certify.ida.include-payload:true}" to a valid Spring placeholder like
"${mosip.certify.ida.include-payload:true}" so the includePayload field is
correctly injected at startup.

In
`@mosip-identity-certify-plugin/src/test/java/io/mosip/certify/mosipid/integration/helper/TransactionHelperTest.java`:
- Around line 43-48: The negative test in TransactionHelperTest calling
transactionHelper.getOAuthTransaction("test") lacks an explicit fail path, so if
the call stops throwing the test will incorrectly pass; update the test method
getOAuthTransactionWithInValidDetails_thenFail to call Assert.fail("Expected
exception not thrown") immediately after the
transactionHelper.getOAuthTransaction("test") invocation (before the catch) and
replace the informal assert in the catch with a proper assertion (e.g.,
Assert.assertEquals("cache_missing", e.getMessage())) to ensure failures are
reported correctly.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: d7fe2867-2fb1-4901-a1bf-05243157f55c

📥 Commits

Reviewing files that changed from the base of the PR and between 5e322a9 and aaddbf0.

📒 Files selected for processing (9)

• mosip-identity-certify-plugin/src/main/java/io/mosip/certify/mosipid/integration/helper/AuthTransactionHelper.java
• mosip-identity-certify-plugin/src/main/java/io/mosip/certify/mosipid/integration/helper/TransactionHelper.java
• mosip-identity-certify-plugin/src/main/java/io/mosip/certify/mosipid/integration/helper/VCIAuthTransactionHelper.java
• mosip-identity-certify-plugin/src/main/java/io/mosip/certify/mosipid/integration/helper/VCITransactionHelper.java
• mosip-identity-certify-plugin/src/main/java/io/mosip/certify/mosipid/integration/service/HelperService.java
• mosip-identity-certify-plugin/src/main/java/io/mosip/certify/mosipid/integration/service/IdaVCIssuancePluginImpl.java
• mosip-identity-certify-plugin/src/main/java/io/mosip/certify/mosipid/integration/service/VCIHelperService.java
• mosip-identity-certify-plugin/src/test/java/io/mosip/certify/mosipid/integration/helper/TransactionHelperTest.java
• mosip-identity-certify-plugin/src/test/java/io/mosip/certify/mosipid/integration/service/IdaVCIssuancePluginImplTest.java

💤 Files with no reviewable changes (3)

• mosip-identity-certify-plugin/src/main/java/io/mosip/certify/mosipid/integration/helper/VCITransactionHelper.java
• mosip-identity-certify-plugin/src/main/java/io/mosip/certify/mosipid/integration/helper/VCIAuthTransactionHelper.java
• mosip-identity-certify-plugin/src/main/java/io/mosip/certify/mosipid/integration/service/VCIHelperService.java