[KATTU-334] Update sonar workflow reference to develop#173
Conversation
Signed-off-by: amanbh321 <Aman.Bahuguna@iiitb.ac.in>
WalkthroughIn ChangesSonar Workflow Reference Update
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/workflows/push-trigger.yml:
- Line 55: Replace all four mutable branch references to
mosip/kattu/.github/workflows/maven-sonar-analysis-new.yml@develop with
immutable commit SHAs. The issue is that using the `@develop` branch reference
allows upstream repository changes to execute unreviewed code with sensitive
secrets like SONAR_TOKEN, OSSRH credentials, GPG_SECRET, and webhook URLs.
Identify the specific commit SHA from the mosip/kattu repository and update each
of the four workflow calls (at lines 55, 96, 137, and 178) to reference the
commit SHA instead of the develop branch, following the format
mosip/kattu/.github/workflows/maven-sonar-analysis-new.yml@COMMIT_SHA.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 47294d9f-ec95-4d3f-ac26-370e469b8378
📒 Files selected for processing (1)
.github/workflows/push-trigger.yml
Summary by CodeRabbit
Note: This release contains only internal infrastructure updates with no user-facing changes.