Skip to content

[KATTU-334] Update sonar workflow reference to develop#173

Open
amanbh321 wants to merge 1 commit into
inji:release-1.0.xfrom
amanbh321:fix-sonar-workflow-reference
Open

[KATTU-334] Update sonar workflow reference to develop#173
amanbh321 wants to merge 1 commit into
inji:release-1.0.xfrom
amanbh321:fix-sonar-workflow-reference

Conversation

@amanbh321

@amanbh321 amanbh321 commented Jun 19, 2026

Copy link
Copy Markdown

Summary by CodeRabbit

  • Chores
    • Updated CI/CD workflow references to use the latest development version.

Note: This release contains only internal infrastructure updates with no user-facing changes.

Signed-off-by: amanbh321 <Aman.Bahuguna@iiitb.ac.in>
@coderabbitai

coderabbitai Bot commented Jun 19, 2026

Copy link
Copy Markdown

Review Change Stack

Walkthrough

In .github/workflows/push-trigger.yml, the reusable workflow reference for maven-sonar-analysis-new.yml is updated from the pinned commit @dsd9685 to the branch @develop in four Sonar analysis jobs, with no other changes to job configuration, conditions, or secrets.

Changes

Sonar Workflow Reference Update

Layer / File(s) Summary
Update sonar workflow ref to @develop in all four jobs
.github/workflows/push-trigger.yml
The uses field in sonar_analysis, sonar_analysis_mosip-identity-certify-plugin, sonar_analysis_mock-certify-plugin, and sonar_analysis_postgres-dataprovider-plugin jobs is changed from maven-sonar-analysis-new.yml@dsd9685 to maven-sonar-analysis-new.yml@develop.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

A rabbit once pinned to a commit so tight,
Four sonar jobs frozen in permanent night.
With one little hop to the develop trail,
The workflows now follow a fresher detail.
🐇✨ Unpinned and free — off we sail!

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and specifically identifies the main change: updating sonar workflow references to use the develop branch instead of a pinned commit. This directly aligns with the changeset.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In @.github/workflows/push-trigger.yml:
- Line 55: Replace all four mutable branch references to
mosip/kattu/.github/workflows/maven-sonar-analysis-new.yml@develop with
immutable commit SHAs. The issue is that using the `@develop` branch reference
allows upstream repository changes to execute unreviewed code with sensitive
secrets like SONAR_TOKEN, OSSRH credentials, GPG_SECRET, and webhook URLs.
Identify the specific commit SHA from the mosip/kattu repository and update each
of the four workflow calls (at lines 55, 96, 137, and 178) to reference the
commit SHA instead of the develop branch, following the format
mosip/kattu/.github/workflows/maven-sonar-analysis-new.yml@COMMIT_SHA.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 47294d9f-ec95-4d3f-ac26-370e469b8378

📥 Commits

Reviewing files that changed from the base of the PR and between a8d1a37 and 8d155d4.

📒 Files selected for processing (1)
  • .github/workflows/push-trigger.yml

Comment thread .github/workflows/push-trigger.yml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants