Skip to content

refactor: remove js folder#116

Merged
swatigoel merged 1 commit into
inji:release-1.0.xfrom
tw-mosip:clean-up-js
Jul 8, 2026
Merged

refactor: remove js folder#116
swatigoel merged 1 commit into
inji:release-1.0.xfrom
tw-mosip:clean-up-js

Conversation

@KiruthikaJeyashankar

@KiruthikaJeyashankar KiruthikaJeyashankar commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

  • Refactor

    • Removed the bundled example app and several related app entry points, screens, and assets.
    • Simplified the library packaging by removing unused module wrappers and declarations.
  • Chores

    • Cleaned up Android, Gradle, TypeScript, Babel, linting, and formatting configuration files.
    • Removed build, wrapper, and publishing setup that was no longer needed.

@coderabbitai

coderabbitai Bot commented Jul 8, 2026

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

@KiruthikaJeyashankar, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 58 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: e8986ffc-d80a-44bb-9016-2c3d6bb3e334

📥 Commits

Reviewing files that changed from the base of the PR and between f342ea2 and eccff97.

⛔ Files ignored due to path filters (21)
  • js/.DS_Store is excluded by !**/.DS_Store
  • js/android/gradle/wrapper/gradle-wrapper.jar is excluded by !**/*.jar
  • js/example/android/app/src/main/res/mipmap-hdpi/ic_launcher.png is excluded by !**/*.png
  • js/example/android/app/src/main/res/mipmap-hdpi/ic_launcher_round.png is excluded by !**/*.png
  • js/example/android/app/src/main/res/mipmap-mdpi/ic_launcher.png is excluded by !**/*.png
  • js/example/android/app/src/main/res/mipmap-mdpi/ic_launcher_round.png is excluded by !**/*.png
  • js/example/android/app/src/main/res/mipmap-xhdpi/ic_launcher.png is excluded by !**/*.png
  • js/example/android/app/src/main/res/mipmap-xhdpi/ic_launcher_round.png is excluded by !**/*.png
  • js/example/android/app/src/main/res/mipmap-xxhdpi/ic_launcher.png is excluded by !**/*.png
  • js/example/android/app/src/main/res/mipmap-xxhdpi/ic_launcher_round.png is excluded by !**/*.png
  • js/example/android/app/src/main/res/mipmap-xxxhdpi/ic_launcher.png is excluded by !**/*.png
  • js/example/android/app/src/main/res/mipmap-xxxhdpi/ic_launcher_round.png is excluded by !**/*.png
  • js/example/android/gradle/wrapper/gradle-wrapper.jar is excluded by !**/*.jar
  • js/example/package-lock.json is excluded by !**/package-lock.json
  • js/example/yalc.lock is excluded by !**/*.lock
  • js/lib/commonjs/index.js.map is excluded by !**/*.map
  • js/lib/module/index.js.map is excluded by !**/*.map
  • js/lib/typescript/__tests__/index.test.d.ts.map is excluded by !**/*.map
  • js/lib/typescript/index.d.ts.map is excluded by !**/*.map
  • js/package-lock.json is excluded by !**/package-lock.json
  • js/yarn.lock is excluded by !**/yarn.lock, !**/*.lock
📒 Files selected for processing (56)
  • .github/workflows/push-trigger.yml
  • js/android/build.gradle
  • js/android/gradle.properties
  • js/android/gradle/wrapper/gradle-wrapper.properties
  • js/android/gradlew
  • js/android/gradlew.bat
  • js/android/local.properties
  • js/android/publish-artifact.gradle
  • js/android/src/main/AndroidManifest.xml
  • js/android/src/main/java/com/reactnativesecurekeystore/RNModule/SecureKeystoreModule.java
  • js/android/src/main/java/com/reactnativesecurekeystore/RNModule/SecureKeystorePackage.java
  • js/babel.config.js
  • js/example/.bundle/config
  • js/example/.eslintrc.js
  • js/example/.gitignore
  • js/example/.prettierrc.js
  • js/example/.watchmanconfig
  • js/example/.yarnrc.yml
  • js/example/App.tsx
  • js/example/Gemfile
  • js/example/README.md
  • js/example/__tests__/App.test.tsx
  • js/example/android/app/build.gradle
  • js/example/android/app/debug.keystore
  • js/example/android/app/proguard-rules.pro
  • js/example/android/app/src/debug/AndroidManifest.xml
  • js/example/android/app/src/main/AndroidManifest.xml
  • js/example/android/app/src/main/java/com/example/MainActivity.kt
  • js/example/android/app/src/main/java/com/example/MainApplication.kt
  • js/example/android/app/src/main/res/drawable/rn_edit_text_material.xml
  • js/example/android/app/src/main/res/values/strings.xml
  • js/example/android/app/src/main/res/values/styles.xml
  • js/example/android/build.gradle
  • js/example/android/gradle.properties
  • js/example/android/gradle/wrapper/gradle-wrapper.properties
  • js/example/android/gradlew
  • js/example/android/gradlew.bat
  • js/example/android/settings.gradle
  • js/example/app.json
  • js/example/babel.config.js
  • js/example/index.js
  • js/example/jest.config.js
  • js/example/metro.config.js
  • js/example/package.json
  • js/example/tsconfig.json
  • js/lefthook.yml
  • js/lib/commonjs/index.js
  • js/lib/module/index.js
  • js/lib/typescript/__tests__/index.test.d.ts
  • js/lib/typescript/index.d.ts
  • js/package.json
  • js/scripts/bootstrap.js
  • js/src/__tests__/index.test.tsx
  • js/src/index.tsx
  • js/tsconfig.build.json
  • js/tsconfig.json

Walkthrough

This PR deletes the entire js/ directory, removing the Android native module (build scripts, Gradle wrapper, manifests, Java source), the example React Native application (source, configs, Android project), library build outputs (CommonJS/module/TypeScript), and root-level configuration files (package.json, tsconfig, babel, lefthook, bootstrap scripts).

Changes

Complete removal of js/ package

Layer / File(s) Summary
Android native module removal
js/android/*
Gradle build scripts, wrapper files, manifest, SecureKeystoreModule.java, SecureKeystorePackage.java, and publishing config all deleted.
Example app removal
js/example/*
React Native example app source, tests, configs, and Android sub-project (Gradle, manifests, Kotlin MainActivity/MainApplication, resources) deleted.
Library build output removal
js/lib/commonjs/*, js/lib/module/*, js/lib/typescript/*
Compiled CommonJS/module JS and TypeScript declaration entrypoints for SecureKeystore deleted.
Root package config removal
js/package.json, js/tsconfig*.json, js/babel.config.js, js/lefthook.yml, js/scripts/bootstrap.js, js/src/*
Package manifest, TypeScript configs, Babel config, lefthook hooks, bootstrap script, and source index.tsx/tests deleted.

Estimated code review effort: 2 (Simple) | ~10 minutes

Poem

A hop, a skip, a final bow,
The js/ burrow's empty now.
Gradle scripts and Kotlin gone,
The example app has moved along.
This rabbit clears the field with care —
🐇 nothing left but tidy air.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main change: removing the js folder and its contents.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Signed-off-by: KiruthikaJeyashankar <kiruthikavjshankar@gmail.com>
@swatigoel swatigoel merged commit a7fd522 into inji:release-1.0.x Jul 8, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants