Skip to content

fix(windows): convert path to file url #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
craftzdog merged 3 commits into from
Mar 10, 2026
Merged

fix(windows): convert path to file url #4

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0a2299b
fix(windows): convert path to file url
craftzdog Mar 9, 2026
e0f9475
fix(windows): avoid using dynamic import statement
craftzdog Mar 9, 2026
44bb30f
chore(publish): remove redundant imports
craftzdog Mar 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 4 additions & 6 deletions src/commands/publish.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
import { rm } from 'fs/promises'
import * as fs from 'fs/promises'
import path from 'path'
import axios, { isAxiosError } from 'axios'
Expand Down Expand Up @@ -48,9 +47,8 @@ export class CommandPublish {
const repoDir = packagePath || process.cwd()

try {
const { default: pkg } = await import(
path.join(repoDir, 'package.json'),
{ with: { type: 'json' } }
const pkg = JSON.parse(
await fs.readFile(path.join(repoDir, 'package.json'), 'utf-8')
)
const repository = this.getRepositoryId(pkg)

Expand All @@ -66,7 +64,7 @@ export class CommandPublish {
await this.uploadTarball(pkg, filePath, repository!, dryrun)

// Step 4 - Clean up the created tarball file
await rm(filePath, { force: true })
await fs.rm(filePath, { force: true })
logger.info('Cleaned up temporary tarball')

logger.info(`Successfully published ${pkg.name}@${pkg.version}`)
Expand Down Expand Up @@ -197,7 +195,7 @@ export class CommandPublish {
const stats = await fs.stat(tarballPath)

if (stats.size > PACKAGE_MAX_SIZE) {
await rm(tarballPath, { force: true })
await fs.rm(tarballPath, { force: true })
throw new Error(
`Package tarball size (${(stats.size / 1024 / 1024).toFixed(2)}MB) exceeds the 30MB limit`
)
Expand Down