fix(ok): resolve mirror-PR fix references by their origin trailer (PRD-7718) (#3085) - #937
Merged
Merged
Conversation
…D-7718) (#3085) * fix(ok): resolve mirror-PR fix references by their origin trailer (PRD-7718) Linear's GitHub linkback attaches the Copybara mirror PR to a ticket whenever the PR title carries the ticket identifier. Write-back treated that reference's merge SHA as a private SHA and trailer-searched it, which can never match (the merge commit IS the mirrored copy), and the all-or-nothing gate then made the whole ticket version-underivable. Self-repo PR references now recover the origin SHA from the merge commit's own GitOrigin-RevId trailer and resolve through the normal mirrored-copy walk, so point-release cherry-picks are found; a trailerless or ambiguous merge commit falls back to direct tag containment of its own SHA. Observed live on the v0.45.1 write-back run: PRD-7715 and PRD-7696 skipped as version-underivable until the echo attachments were deleted by hand. * Keep private-repo PRs on the trailer-search path when selfRepo is the origin GITHUB_REPOSITORY equals the private repo in agents-private CI, which routed private PR refs through the mirror-side branch and broke derivation there. * Log the trailerless/ambiguous fallback and pin it plus isSelfRepoPr with tests GitOrigin-RevId: 21c2fd4388e02c20790eb9933f3e2d087d772a68
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Copybara-translated 1 Inkeep OSS change. Rebase-merge this PR so the prepared commit lands directly on public main.