KV interface for stored Evaluables in aggregate engines #35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows evals to be stored on disk via eg. a Pebble KV store.
tonyhb
commented
Apr 29, 2025
| type ExpressionEvaluator func(ctx context.Context, e Evaluable, input map[string]any) (bool, error) | ||
|
|
||
| // EvaluableLoader returns one or more evaluable items given IDs. | ||
| type EvaluableLoader func(ctx context.Context, evaluableIDs ...uuid.UUID) ([]Evaluable, error) |
Contributor
Author
There was a problem hiding this comment.
cleanup - this is unused.
tonyhb
commented
Apr 29, 2025
| // | ||
| // An AggregateEvaluator instance exists for every event name being matched. | ||
| type AggregateEvaluator interface { | ||
| type AggregateEvaluator[T Evaluable] interface { |
Contributor
Author
There was a problem hiding this comment.
For the sake of the review, we must store a concrete type in the aggregator for marshalling to and from the concrete type in the KV storage. This requires generics.
tonyhb
commented
Apr 29, 2025
| // Attempt to unmarshal an empty byte slice, ensuring that we have | ||
| // a concrete type instead of an interface. | ||
| if _, err := kvopts.Unmarshal([]byte("{}")); err != nil { | ||
| panic(fmt.Sprintf("unable to make KV for aggregate evaluator without concrete type: %s", err)) |
Contributor
Author
There was a problem hiding this comment.
this allows us to fail fast in unit tests, but will never hit in our services — KVOpts will always pass in a KV constructor.
BrunoScheufler
approved these changes
Apr 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements a KV storage interface for the aggregate expression engine. This lets us provide a new PebbleDB instance into aggregate engines, meaning that pauses will be written to disk instead of stored in memory.