docs(handoff): dl-router Discord media β three PRs merged and shipped, and the consumer is MEASURED not to be running them - #1236
Open
ZacxDev wants to merge 3 commits into
Open
Conversation
β¦#1110 save the posted file no Claude-Session-Id: 604aabe0-8379-4a24-add1-20f32d7011fd
β¦it is now answered by measureme Claude-Session-Id: e13f042e-3be9-449d-a597-4b9a7ea7d259
β¦very round after the first foun Claude-Session-Id: e13f042e-3be9-449d-a597-4b9a7ea7d259
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New effort, new doc β the two existing dl-router handoffs are closed retrospectives of the July/August build-out with dated slugs, not this work.
Discord is 59% of dl-router's live traffic (20 of 34 routed downloads) and the routing half has been Discord-specific since the first evening β but the save side was wrong for it in three ways. All three merged and shipped:
911af2204fdead27discord-embed-extdoc β crop VERIFIED LIVE, plus three corrections67f674f6mediamay be an ORDERED LIST of accessors, so one rule covers an anchor-linked image AND a direct videoThe part that matters most
π΄ Deployed β running. After the operator reported reloading, I measured Brave's own record:
0.3.2, written 08-31 02:41Preferences)Brave is still running 0.3.1. That is what the manifest bump exists to detect, and it is rank 1 in the doc with
forcing: user.Open investigation carried forward
Whether
preferOriginalUrlis a no-op in production. The defect it fixes is proven (pre-change code demonstrably downloadsβ¦?format=webp&width=550), but all 20 live Discord rows are origin-host, so the proxy branch has no live instance behind it β and the extension has no logging facility, so the question has no data-driven answer. The doc carries the DOM probe that settles it, and both eliminations are taggedvia: measurementwith the untested part named explicitly.Also recorded
The two-writers-one-reader ledger seam and why
buildMatchPayloadis deliberately not folded in (pinned by three pre-existing tests); whystore.source_url_keykeeps the query on purpose and Discord is the exception; the hand-copiedMAX_MEDIA_ACCESSORSthat left both suites green when only one side moved; that a menu test asserting onlydownloads.length === 0is vacuous (hit twice in one PR); and the asymmetric deploy order β switch first, rule second, or a list rule against the old sidecar takes every routing endpoint to 503.Docs-only: one file.
π€ Generated with Claude Code