Fix test after changes in shiny package #684
Open
osenan wants to merge 2 commits into
Open
Conversation
Contributor
|
✅ All contributors have signed the CLA |
Contributor
Author
|
I have read the CLA Document and I hereby sign the CLA |
Contributor
Code Coverage SummaryDiff against mainResults for commit: 09f3f10 Minimum allowed coverage is ♻️ This comment has been updated with latest results |
Contributor
Unit Tests Summary 1 files 32 suites 40s ⏱️ Results for commit 09f3f10. ♻️ This comment has been updated with latest results. |
Contributor
Unit Test Performance Difference
Results for commit 3560eb1 ♻️ This comment has been updated with latest results. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
This is modifying failing tests after the changes reported here #682. This PR is strictly addressing the failing tests only. There are messages when running the test related to reactive values destroyed that should be fixed as well. This PR is solving, for the moment, the most urgent changes that make the package not pass the checks in CRAN or in CI.
For the review it, it needs at least to pass CI. Locally tests are passing.