added new method hasValueChanged to check to see if a new value would…#16
Open
mdgbayly wants to merge 1 commit intoinsin:masterfrom
Open
added new method hasValueChanged to check to see if a new value would…#16mdgbayly wants to merge 1 commit intoinsin:masterfrom
mdgbayly wants to merge 1 commit intoinsin:masterfrom
Conversation
… change the output value of the mask
Author
|
Refer to insin/react-maskedinput#38 for related react-maskedinput PR |
| if (!nextValue) { | ||
| nextValue = '' | ||
| } | ||
| return this.value.join('') !== this.pattern.formatValue(nextValue.split('')).join('') |
Collaborator
There was a problem hiding this comment.
Why is this doing a join? (Apologies if the question is a bit naive. I have access to this repo, but haven’t read any of the implementation)
Author
There was a problem hiding this comment.
Few months since I looked at this, but I think it's because InputMask stores its internal representation of the field data as an array. Don't recall exactly why, but all related to how it processes the mask characters I believe.
Contributor
|
Please add documentation for this new method to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… change the output value of the mask
This is a new method that will be used by react-maskedinput to determine if new props will change the mask value.
It is to fix an issue in react-maskedinput where the onChange handler passed to the input rejects a change. In our case preventing people from entering a percentage value > 100%
mask: '111%'
Type: 9
MaskValue: 9%
Type: 9
MaskValue: 99%
Type: 9
MaskValue: 999%
But the value of 999 is rejected by onChange handler so component re-renders with props of 99 again. But the mask does not re-render as componentWillReceiveNewProps checks to see if props have changed and in this case have not.
A related fix in react-maskedinput will use this new method rather than just checking props to determine if it should update the mask value.