Make it so that conf/*.sh can be trivially overridden by the user#91
Make it so that conf/*.sh can be trivially overridden by the user#91ctm wants to merge 1 commit intoinspircd:masterfrom ctm:consistent_configuration
Conversation
Closes #90 Prior to this commit, editing the conf/*.conf files resulted in changed configuration parameters, but editing the conf/*.sh files did not. Furthermore, there was a comment in the conf/*.sh files that could be misconstrued. With this commit the conf/*.sh and conf/*.conf files behave the same. conf/*.sh files can be edited and then docker -v can be used to bind mount the conf directory and the changes will take effect.
|
This all can be solved by fixing the bug introduced by the rewrite to multi-staged builds that moved the workdir from Also the warnings were added to the files to prevent users from modifying those files within the repository because they thought those would be mounted to the image. Within the image or before you build the image, you can do with those files what you want :) |
Essentially, yes! 😁 I noticed this the other day when trying to use 'conf.d', but it was not doing anything. I am laying out a PR for this (and other slightly related issues) at https://github.com/HumorBaby/inspircd-docker/commits/fix-refactor-tests; specifically, I think |
|
Also, sorry @ctm!
is why I jumped on replying to #90 so fast 🐱 I had been tracing through the |
|
I have no desire to see this PR merged, per-se. I provided it more as a concrete example of what I was (perhaps poorly) describing. I was surprised that the I misconstrued the comments in the Eventually I realized there were two copies of the I have no doubt that SISheogorath has better ideas than this PR. |
Closes #90
Prior to this commit, editing the conf/.conf files resulted in
changed configuration parameters, but editing the conf/.sh files did
not. Furthermore, there was a comment in the conf/*.sh files that
could be misconstrued.
With this commit the conf/.sh and conf/.conf files behave the same.
conf/*.sh files can be edited and then docker -v can be used to bind
mount the conf directory and the changes will take effect.
Checklist