Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 22 additions & 1 deletion client/packages/core/__tests__/src/utils/PersistedObject.test.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import 'fake-indexeddb/auto';
import { test, expect, describe } from 'vitest';
import { test, expect, describe, vi } from 'vitest';
import { PersistedObject } from '../../../src/utils/PersistedObject';
import { IndexedDBStorage } from '../../../src';
import { randomUUID } from 'crypto';
Expand Down Expand Up @@ -423,3 +423,24 @@ test('IndexedDBStorage recovers when the database connection closes', async () =
await idb.removeItem('key4');
expect(await idb.getItem('key4')).toBe(null);
});

test('IndexedDBStorage explicitly commits write transactions', async () => {
const commitSpy = vi.spyOn(IDBTransaction.prototype, 'commit');
try {
const idb = new IndexedDBStorage(randomUUID(), 'kv');

await idb.setItem('key1', 'value1');
await idb.multiSet([
['key2', 'value2'],
['key3', 'value3'],
]);
await idb.removeItem('key3');

expect(commitSpy).toHaveBeenCalledTimes(3);
expect(await idb.getItem('key1')).toBe('value1');
expect(await idb.getItem('key2')).toBe('value2');
expect(await idb.getItem('key3')).toBe(null);
} finally {
commitSpy.mockRestore();
}
});
3 changes: 3 additions & 0 deletions client/packages/core/src/IndexedDBStorage.ts
Original file line number Diff line number Diff line change
Expand Up @@ -300,6 +300,7 @@ export default class IndexedDBStorage extends StoreInterface {
transaction.oncomplete = () => resolve();
transaction.onerror = () => reject(transaction.error);
transaction.onabort = () => reject(transaction.error);
transaction.commit?.();
});
});
}
Expand All @@ -316,6 +317,7 @@ export default class IndexedDBStorage extends StoreInterface {
transaction.oncomplete = () => resolve();
transaction.onerror = () => reject(transaction.error);
transaction.onabort = () => reject(transaction.error);
transaction.commit?.();
});
});
}
Expand All @@ -330,6 +332,7 @@ export default class IndexedDBStorage extends StoreInterface {
transaction.oncomplete = () => resolve();
transaction.onerror = () => reject(transaction.error);
transaction.onabort = () => reject(transaction.error);
transaction.commit?.();
});
});
}
Expand Down
2 changes: 1 addition & 1 deletion client/packages/version/src/version.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,6 @@
// Update the version here and merge your code to main to
// publish a new version of all of the packages to npm.

const version = 'v1.0.63';
const version = 'v1.0.64';

export { version };
Loading