This repository was archived by the owner on Aug 7, 2026. It is now read-only.
fix: make change tracker compatible with Ember 5 - #1
Draft
eyupatis wants to merge 5 commits into
Draft
Conversation
…assign modelChanges() had its own direct Ember.assign call that was missed in the initial fix (only tracker.js's internal assign helper was updated). Ember.assign is fully removed in Ember 5.x, not just deprecated.
…lookup
ember-data 5.x no longer auto-registers the classic private serializer:-rest
name (used as a fallback REST serializer for rollback normalization), so
container.lookup('serializer:-rest') returned undefined. store.serializerFor
is the supported, model-aware replacement.
…mmits The fork stayed at the upstream 0.10.1 version string across multiple fix commits, causing yarn's local cache to occasionally serve stale tarballs for this exact name+version combination even when yarn.lock pointed to a newer commit SHA.
eyupatis
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Modelfrom the public@ember-data/modelpackageEmber.assignwithObject.assignstore.serializerForAPIChangeTrackerMixinand stop globally patching every Ember Data model withModel.reopenThe Instrumentl app consumes this branch in instrumentl/instrumentl#22071 and composes the exported mixin explicitly in instrumentl/instrumentl#22075.
Why
These changes remove the deprecated/private APIs that block the Ember Data 5 upgrade without adding compatibility monkey patches. Explicit mixin composition also limits change-tracking behavior to the models that use it.