Skip to content

fix: resolve co-located templates via getComponentTemplate - #1

Open
eyupatis wants to merge 2 commits into
addon-modernizationfrom
colocated-island-templates
Open

fix: resolve co-located templates via getComponentTemplate#1
eyupatis wants to merge 2 commits into
addon-modernizationfrom
colocated-island-templates

Conversation

@eyupatis

Copy link
Copy Markdown

Summary

Island components rendered via data-component placeholders get their template from owner.lookup('template:components/<name>'), which only works for separately-resolved (pods) templates. Ember 5.9+ deprecates that resolution path (component-template-resolving, fatal under instrumentl's throw deprecation workflow), so instrumentl#22122 co-locates all island component templates — which removes the separately-resolvable template module and made islands render empty (e.g. Quick Find).

Proposed solution

  • Read the template off the component class first via getComponentTemplate(component.class) — the same order Ember's own lookupComponentPair uses — and fall back to the legacy template:components/<name> lookup for any remaining pods components.

How to test this

  • instrumentl#22122 consumes this branch ref and adds an integration regression test (tests/integration/components/ember-islands-test.js) that renders an island with a co-located template: fails against addon-modernization, passes with this change.

🤖 Generated with Claude Code

eyupatis and others added 2 commits July 24, 2026 18:24
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant