fix: resolve co-located templates via getComponentTemplate - #1
Open
eyupatis wants to merge 2 commits into
Open
Conversation
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Island components rendered via
data-componentplaceholders get their template fromowner.lookup('template:components/<name>'), which only works for separately-resolved (pods) templates. Ember 5.9+ deprecates that resolution path (component-template-resolving, fatal under instrumentl'sthrowdeprecation workflow), so instrumentl#22122 co-locates all island component templates — which removes the separately-resolvable template module and made islands render empty (e.g. Quick Find).Proposed solution
getComponentTemplate(component.class)— the same order Ember's ownlookupComponentPairuses — and fall back to the legacytemplate:components/<name>lookup for any remaining pods components.How to test this
tests/integration/components/ember-islands-test.js) that renders an island with a co-located template: fails againstaddon-modernization, passes with this change.🤖 Generated with Claude Code