fix: stop relying on the removed Ember.Handlebars global for escaping - #1
Open
eyupatis wants to merge 1 commit into
Open
fix: stop relying on the removed Ember.Handlebars global for escaping#1eyupatis wants to merge 1 commit into
eyupatis wants to merge 1 commit into
Conversation
Ember 6 drops the Ember.Handlebars namespace entirely, so Ember.Handlebars.Utils.escapeExpression throws at render time for any consumer on Ember >= 6. Replace it with Handlebars' own well-known escaping implementation, copied verbatim, and drop the now-unused Ember import.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Ember 6 removes the
Ember.Handlebarsnamespace entirely. The{{linkify}}helper still callsEmber.Handlebars.Utils.escapeExpression(params[0])directly with no fallback, which throws at render time for any consumer on Ember >= 6.This bug is not fixed in any upstream release (checked all 24 npm versions up to 4.1.2) or in the most recent open upstream PR (johnotander/ember-linkify#43).
Proposed solution
Replace the call with Handlebars' own well-known escaping implementation, copied verbatim. Drops the now-unused
Emberimport.How to test this
ember test --filter linkify— 16/16 pass, including the two tests that exercise HTML escaping directly.