Skip to content

LuaLS as language server for Monaco editor#1470

Open
SukuWc wants to merge 31 commits intostablefrom
kkerti-luaLS
Open

LuaLS as language server for Monaco editor#1470
SukuWc wants to merge 31 commits intostablefrom
kkerti-luaLS

Conversation

@SukuWc
Copy link
Copy Markdown
Member

@SukuWc SukuWc commented Apr 2, 2026

Summary

  • Integrates LuaLS (Lua Language Server) with the Monaco editor via a WebSocket bridge
  • Spawns LuaLS as a child process on the main thread, bridges stdio ↔ WebSocket for LSP JSON-RPC in the renderer
  • Adds ---@meta annotations for the Grid Lua API (build-assets/lua-annotations/grid-api.lua) enabling completions, hover, signature help, and semantic tokens

Test plan

  • Verify completions appear for Grid API globals in the Monaco editor
  • Verify hover and signature help work on function calls
  • Verify LuaLS binary downloads correctly via postinstall on all platforms (macOS arm64/x64, Windows, Linux)
  • Verify app builds and packages correctly with LuaLS binaries in extraResources
  • Verify CI build matrix includes the LuaLS download step

🤖 Generated with Claude Code

kkerti and others added 30 commits March 5, 2026 21:47
…g luaLS, try to have feature parity with previous implementation
LuaLS runs as a process in Electron main and bridges over ws://localhost:8089.
In the web-only CI environment there is no backend, so suggestions never appear
and these tests always fail.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 2, 2026

Visit the preview URL for this PR (updated for commit e5969f7):

https://grid-editor-web--pr1470-kkerti-luals-7g049xzp.web.app

(expires Sat, 02 May 2026 06:10:14 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 2b65ba6ef19c55d367eaffd04e46bcde25305d6f

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 2, 2026

Visit the preview URL for this PR (updated for commit e5969f7):

https://grid-playwright-result--pr1470-kkerti-luals-risdzy28.web.app

(expires Sun, 05 Apr 2026 06:18:16 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 0f764ceb264072188bf1a5dee10613d8f10b4ca2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants