Skip to content

Conversation

@ethanglaser
Copy link
Member

@ethanglaser ethanglaser commented Dec 18, 2025

Several CI related cleanup/refactoring tasks, functionality should largely be unaffected. So far:

  • Replaces renovate with dependabot to align with private source repo, with monthly scans for actions updates
  • Set all actions to the latest stable major version for consistency
  • Migrate CI-related bash scripts from docker/ to .github/scripts/
  • Remove unnecessary chmod on above scripts
  • Update cpp bindings and shared examples CMakeLists.txt to reference latest release binaries
  • Throw error if ctests aren't found in shared/bindings validation
  • Run Faiss-SVS examples for validation in addition to tests

@ethanglaser ethanglaser changed the title Dev/eglaser ghactions refactoring GitHub actions and general CI maintenance Dec 18, 2025
@ethanglaser ethanglaser marked this pull request as ready for review February 3, 2026 02:27
else
echo "Non-Intel CPU detected - SVS python example expected to fail"
set +e
PYTHONPATH=../../build/faiss/python/build/lib/ OMP_NUM_THREADS=8 python 11-SVS.py
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we will be running on 4 hardware threads.

Suggested change
PYTHONPATH=../../build/faiss/python/build/lib/ OMP_NUM_THREADS=8 python 11-SVS.py
PYTHONPATH=../../build/faiss/python/build/lib/ OMP_NUM_THREADS=4 python 11-SVS.py

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants