Add new spacing rules pending from DML style guide by jvsqzj · Pull Request #108 · intel/dml-language-server

jvsqzj · 2025-05-29T01:36:10Z

Address pending rules tracked in issue #71

SP.reserved: spaces around reserved words, such as if, else, default, size, const and in, except when a reserved word is used as an identifier (e.g., local uint8 *data;) - @alecalvop
SP.binop: spaces around binary operators except the dereferencing operators dot (a.b) and arrow (a->b) - @jvsqzj
SP.ternary: spaces around ? and : in the ternary ?: operator - @jvsqzj
SP.ptrdecl: space between a type and the * marking a pointer - @dtarassenko
NSP.ptrdecl: no space after the * marking a pointer in a declaration - @dtarassenko

jvsqzj · 2025-07-03T22:54:04Z

There seems to be a problem with the #[serde(default)] attribute we use for LintCfg and its fields.
If one forgets to add it, then the test_example_lintcfg will pass even if the example_lintcfg.json file does not have the added rule.

We should make this clear to avoid this type of silent issues.

jvsqzj · 2025-08-14T21:20:41Z

There seems to be a problem with the #[serde(default)] attribute we use for LintCfg and its fields. If one forgets to add it, then the test_example_lintcfg will pass even if the example_lintcfg.json file does not have the added rule.

We should make this clear to avoid this type of silent issues.

This is now handled by #130 and should be merged soon to resolve this problem

jvsqzj · 2025-08-14T21:28:45Z

@JonatanWaern I think it functionality here is complete. Please do a review round for feedback.

JonatanWaern

Nice work! needs a few changes (see also clippy part of build) and a changelog entry

src/lint/rules/spacing.rs

src/lint/rules/tests/spacing/mod.rs

src/lint/rules/spacing.rs

jvsqzj · 2025-09-22T22:22:07Z

Nice work! needs a few changes (see also clippy part of build) and a changelog entry

I think all suggestions are addressed now.

JonatanWaern

Needs a rebase on main, which seems to have conflicts (likely due to my in-line lint annotation change, which also touches the tests on lint/mod.rs level.)

src/lint/features.md

src/lint/rules/spacing.rs

JonatanWaern · 2025-09-30T10:08:10Z

@alecalvop Are you looking to merge this soon? I was planning to make a release this week so we can likely squeeze it in before

Use robust check for spacing tests

* Add pointer declaration spacing rules * Remove NspPtrDecl disable

* Add sp_binop.rs to spacing rule tests module for BinaryExpressionContent * Add sp_ternary rule for ? : conditionals for TertiaryExpressionContent

* Add SP Reserved spacing rule * Add support for `while` `for` and `else` * Add rule documentation * Add rule to example_lint_cfg.json --------- Co-authored-by: Vasquez Alfaro, Juan J <juan.j.vasquez.alfaro@intel.com>

alecalvop · 2025-09-30T18:13:26Z

@alecalvop Are you looking to merge this soon? I was planning to make a release this week so we can likely squeeze it in before

@JonatanWaern Yes, I have addressed the comments

JonatanWaern

Looks good, nice work!

jvsqzj force-pushed the feature/71-spacing-pending-rules branch from e2b4518 to 4cc5936 Compare May 29, 2025 18:30

jvsqzj mentioned this pull request May 29, 2025

Refactor lint spacing tests kevv87/dml-language-server#16

Closed

jvsqzj force-pushed the feature/71-spacing-pending-rules branch from 2af6f35 to 76b5474 Compare July 3, 2025 22:14

jvsqzj force-pushed the feature/71-spacing-pending-rules branch from f90a029 to 8b336dd Compare July 17, 2025 22:26

jvsqzj marked this pull request as ready for review August 14, 2025 21:25

jvsqzj force-pushed the feature/71-spacing-pending-rules branch from 8b18048 to 06c848a Compare August 14, 2025 21:27

JonatanWaern reviewed Aug 15, 2025

View reviewed changes

src/lint/rules/spacing.rs Outdated Show resolved Hide resolved

src/lint/rules/spacing.rs Outdated Show resolved Hide resolved

src/lint/rules/tests/spacing/mod.rs Show resolved Hide resolved

JonatanWaern reviewed Sep 8, 2025

View reviewed changes

src/lint/rules/spacing.rs Outdated Show resolved Hide resolved

src/lint/rules/spacing.rs Outdated Show resolved Hide resolved

src/lint/rules/spacing.rs Outdated Show resolved Hide resolved

JonatanWaern reviewed Sep 26, 2025

View reviewed changes

src/lint/features.md Outdated Show resolved Hide resolved

src/lint/rules/spacing.rs Show resolved Hide resolved

alecalvop and others added 13 commits September 30, 2025 10:51

Refactor lint spacing tests

97e8fe3

Use robust check for spacing tests

Add pointer declaration spacing rule (SP.ptrdecl) (#20)

461b3eb

* Add pointer declaration spacing rules * Remove NspPtrDecl disable

Fix outdated push_err call and unit-tests

1400e63

Add sp_binop and sp_ternary rules to lint module checks (#19)

55793ba

* Add sp_binop.rs to spacing rule tests module for BinaryExpressionContent * Add sp_ternary rule for ? : conditionals for TertiaryExpressionContent

Add SP Reserved spacing rule (#21)

5f19219

* Add SP Reserved spacing rule * Add support for `while` `for` and `else` * Add rule documentation * Add rule to example_lint_cfg.json --------- Co-authored-by: Vasquez Alfaro, Juan J <juan.j.vasquez.alfaro@intel.com>

Make name() return value lowercase for consistency

5d072b1

Add ptrdecl rules to supported features documentation

a679c88

Misc consistency changes

9eb4fe5

Fix clippy reports

732f0b7

Address code review suggestions

3552eba

Update features.md

c0b1ab6

Update SpTernaryRule reported ranges

0055369

Add CHANGELOG entry

1db4874

alecalvop force-pushed the feature/71-spacing-pending-rules branch from a9d1b48 to 1db4874 Compare September 30, 2025 17:08

JonatanWaern approved these changes Oct 1, 2025

View reviewed changes

JonatanWaern merged commit a13c1d8 into intel:main Oct 1, 2025
4 checks passed

alecalvop mentioned this pull request Oct 3, 2025

Some spacing style rules pending implementation #71

Closed

Conversation

jvsqzj commented May 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jvsqzj commented Jul 3, 2025

Uh oh!

jvsqzj commented Aug 14, 2025

Uh oh!

jvsqzj commented Aug 14, 2025

Uh oh!

JonatanWaern left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jvsqzj commented Sep 22, 2025

Uh oh!

JonatanWaern left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

JonatanWaern commented Sep 30, 2025

Uh oh!

alecalvop commented Sep 30, 2025

Uh oh!

JonatanWaern left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

jvsqzj commented May 29, 2025 •

edited

Loading