Skip to content

Fix space escape in --cl-options="-s /path\ with\ spaces/kernel.cl"#712

Merged
wenju-he merged 1 commit into
intel:mainfrom
wenju-he:fix-space-escape
Jun 1, 2026
Merged

Fix space escape in --cl-options="-s /path\ with\ spaces/kernel.cl"#712
wenju-he merged 1 commit into
intel:mainfrom
wenju-he:fix-space-escape

Conversation

@wenju-he
Copy link
Copy Markdown
Contributor

@wenju-he wenju-he commented May 30, 2026

Fixes test Manual/testsuite/s-option.cl in #715.

Bug: delimiter branch ignores is_escaped, so \ (backslash-space) breaks the token instead of inserting a literal space.

Two fixes:

  • escape char: don't add to tok; set is_escaped=true, or if already escaped emit literal \ and clear flag.
  • Delimiter: check is_escaped (not just in_quote) before breaking token; clear is_escaped after consuming.

Assisted-by: Claude

Bug: delimiter branch ignores is_escaped, so \  (backslash-space) breaks the
token instead of inserting a literal space.

Two fixes:
- escape char: don't add to tok; set is_escaped=true, or if already
  escaped emit literal \ and clear flag.
- Delimiter: check is_escaped (not just in_quote) before breaking token;
  clear is_escaped after consuming.

Assisted-by: Claude
@wenju-he wenju-he enabled auto-merge (squash) May 30, 2026 07:30
@wenju-he wenju-he merged commit 65b270e into intel:main Jun 1, 2026
4 checks passed
@wenju-he wenju-he deleted the fix-space-escape branch June 1, 2026 03:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants