Skip to content

fix: Strip host-write-only flag and cover all capture-replay allocations #486

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bashbaug merged 1 commit into from
Sep 7, 2026
+27 −3
Merged

fix: Strip host-write-only flag and cover all capture-replay allocations #486

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 27 additions & 3 deletions intercept/src/dispatch.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -992,9 +992,10 @@ CL_API_ENTRY cl_mem CL_API_CALL CLIRN(clCreateBuffer)(

if( pIntercept->config().CaptureReplay )
{
// Make sure that there are no device only buffers
// Since we need them to replay the kernel
flags &= ~CL_MEM_HOST_NO_ACCESS;
// Make sure that there are no device only or host write only
// buffers, since we need to read buffer contents back on the
// host to dump and replay the kernel.
flags &= ~( CL_MEM_HOST_NO_ACCESS | CL_MEM_HOST_WRITE_ONLY );
}
INITIALIZE_BUFFER_CONTENTS_INIT( flags, size, host_ptr );
CHECK_ERROR_INIT( errcode_ret );
Expand Down Expand Up @@ -1052,6 +1053,13 @@ CL_API_ENTRY cl_mem CL_API_CALL CLIRN(clCreateBufferWithProperties)(
flags,
size,
host_ptr );
if( pIntercept->config().CaptureReplay )
{
// Make sure that there are no device only or host write only
// buffers, since we need to read buffer contents back on the
// host to dump and replay the kernel.
flags &= ~( CL_MEM_HOST_NO_ACCESS | CL_MEM_HOST_WRITE_ONLY );
}
INITIALIZE_BUFFER_CONTENTS_INIT( flags, size, host_ptr );
CHECK_ERROR_INIT( errcode_ret );
HOST_PERFORMANCE_TIMING_START();
Expand Down Expand Up @@ -1305,6 +1313,14 @@ CL_API_ENTRY cl_mem CL_API_CALL CLIRN(clCreateImage)(
CHECK_ERROR_INIT( errcode_ret );
HOST_PERFORMANCE_TIMING_START();

if( pIntercept->config().CaptureReplay )
{
// Make sure that there are no device only or host write only
// images, since we need to read image contents back on the
// host to dump and replay the kernel.
flags &= ~( CL_MEM_HOST_NO_ACCESS | CL_MEM_HOST_WRITE_ONLY );
}

cl_mem retVal = pIntercept->dispatch().clCreateImage(
context,
flags,
Expand Down Expand Up @@ -1395,6 +1411,14 @@ CL_API_ENTRY cl_mem CL_API_CALL CLIRN(clCreateImageWithProperties)(
CHECK_ERROR_INIT( errcode_ret );
HOST_PERFORMANCE_TIMING_START();

if( pIntercept->config().CaptureReplay )
{
// Make sure that there are no device only or host write only
// images, since we need to read image contents back on the
// host to dump and replay the kernel.
flags &= ~( CL_MEM_HOST_NO_ACCESS | CL_MEM_HOST_WRITE_ONLY );
}

cl_mem retVal = pIntercept->dispatch().clCreateImageWithProperties(
context,
properties,
Expand Down
Loading