Amd c adapter proposal#3
Open
remythales wants to merge 15 commits intointel:mainfrom
Open
Conversation
Signed-off-by: Remy saksik <remy.saksik@thalesgroup.com>
Signed-off-by: Remy saksik <remy.saksik@thalesgroup.com>
…nd, improve code rereadability Signed-off-by: Remy saksik <remy.saksik@thalesgroup.com>
Signed-off-by: Remy saksik <remy.saksik@thalesgroup.com>
… at the ERROR label Signed-off-by: Remy saksik <remy.saksik@thalesgroup.com>
Signed-off-by: Remy saksik <remy.saksik@thalesgroup.com>
…y space Signed-off-by: Remy saksik <remy.saksik@thalesgroup.com>
Signed-off-by: Remy saksik <remy.saksik@thalesgroup.com>
Signed-off-by: Remy saksik <remy.saksik@thalesgroup.com>
Tdx memory allocation patch
Signed-off-by: Remy saksik <remy.saksik@thalesgroup.com>
Signed-off-by: Remy saksik <remy.saksik@thalesgroup.com>
Signed-off-by: Remy saksik <remy.saksik@thalesgroup.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AMD Adapter Implementation Proposal
Overview
This pull request introduces an initial implementation of an AMD Adapter. The primary goal of this submission is to share the proposal with the team and allow you to cherry-pick relevant changes.
The adapter has been tested on an Azure AMD machine, and the detailed build steps are documented in the
README-AMD.mdfile. Additionally, a memory check has been performed on the generated binary to ensure stability and performance.Key Points:
Implementation: The creation of the adapter (
xxx_adapter_new) and its associated memory management function (xxx_adapter_free) do not need to be tied to a specific hardware vendor (such as TDX/AMD). Instead, they are designed to be more generic for use on platforms like Azure. However, for now, I have kept the functionality separated to ensure clarity and maintain consistency with the existing structure.Variable Consolidation: Some variables have the same values for both the TDX and AMD adapters. We could consolidate these to avoid duplicated values, but for now, I have kept them separated to ensure clarity.
Build Process: I have adhered to the current build process and refrained from adding a separate
amd-sev-snpfolder to maintain alignment with the existing workflow. Future improvements can be made to streamline and optimize the build process.Next Steps: While the current implementation includes both TDX and AMD functions within the same library, a future revision of the library's naming convention would help to better differentiate between the TDX and AMD functionalities. There is also room for optimization and further refinements in the build process.
Notes for Review:
Thank you for reviewing this proposal, and I look forward to your feedback!