Skip to content

Amd c adapter proposal#3

Open
remythales wants to merge 15 commits intointel:mainfrom
ThalesGroup:amd-c-adapter-proposal
Open

Amd c adapter proposal#3
remythales wants to merge 15 commits intointel:mainfrom
ThalesGroup:amd-c-adapter-proposal

Conversation

@remythales
Copy link
Copy Markdown
Contributor

AMD Adapter Implementation Proposal

Overview

This pull request introduces an initial implementation of an AMD Adapter. The primary goal of this submission is to share the proposal with the team and allow you to cherry-pick relevant changes.

The adapter has been tested on an Azure AMD machine, and the detailed build steps are documented in the README-AMD.md file. Additionally, a memory check has been performed on the generated binary to ensure stability and performance.

Key Points:

  • Implementation: The creation of the adapter (xxx_adapter_new) and its associated memory management function (xxx_adapter_free) do not need to be tied to a specific hardware vendor (such as TDX/AMD). Instead, they are designed to be more generic for use on platforms like Azure. However, for now, I have kept the functionality separated to ensure clarity and maintain consistency with the existing structure.

  • Variable Consolidation: Some variables have the same values for both the TDX and AMD adapters. We could consolidate these to avoid duplicated values, but for now, I have kept them separated to ensure clarity.

  • Build Process: I have adhered to the current build process and refrained from adding a separate amd-sev-snp folder to maintain alignment with the existing workflow. Future improvements can be made to streamline and optimize the build process.

  • Next Steps: While the current implementation includes both TDX and AMD functions within the same library, a future revision of the library's naming convention would help to better differentiate between the TDX and AMD functionalities. There is also room for optimization and further refinements in the build process.

Notes for Review:

  • The adapter’s creation is designed to be independent of the specific hardware vendor (TDX/AMD) and is intended to work more generically for platform environments like Azure.
  • The current structure includes both TDX and AMD-specific functions within the same library. The library's name should be reconsidered for better clarity and distinction.
  • Consider further optimizations to the build process in future updates, especially with respect to simplifying the integration of platform-specific functionality.

Thank you for reviewing this proposal, and I look forward to your feedback!

remythales and others added 15 commits December 5, 2024 11:07
Signed-off-by: Remy saksik <remy.saksik@thalesgroup.com>
Signed-off-by: Remy saksik <remy.saksik@thalesgroup.com>
…nd, improve code rereadability

Signed-off-by: Remy saksik <remy.saksik@thalesgroup.com>
Signed-off-by: Remy saksik <remy.saksik@thalesgroup.com>
… at the ERROR label

Signed-off-by: Remy saksik <remy.saksik@thalesgroup.com>
Signed-off-by: Remy saksik <remy.saksik@thalesgroup.com>
…y space

Signed-off-by: Remy saksik <remy.saksik@thalesgroup.com>
Signed-off-by: Remy saksik <remy.saksik@thalesgroup.com>
Signed-off-by: Remy saksik <remy.saksik@thalesgroup.com>
Signed-off-by: Remy saksik <remy.saksik@thalesgroup.com>
Signed-off-by: Remy saksik <remy.saksik@thalesgroup.com>
Signed-off-by: Remy saksik <remy.saksik@thalesgroup.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant