Fixed key pair generation issue#50
Open
cowbon wants to merge 1 commit intointel:mainfrom
Open
Conversation
tdx.GenerateKeyPair hard-codes the PEM block type as "PRIVATE KEY" while serializing the bytes with x509.MarshalPKCS1PrivateKey, the output is indeed PKCS#1 data wrapped in a PKCS#8-style label. This causes the error to load the private key generated by trustauthority-cli. PKCS#1 should use Type: "RSA PRIVATE KEY" wheras PKCS#8 should use Type: "PRIVATE KEY". Align the header with the payload without changing the logic. Signed-off-by: Ian Chin Wang <ian.chin.wang@oracle.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tdx.GenerateKeyPair hard-codes the PEM block type as "PRIVATE KEY" while serializing the bytes with x509.MarshalPKCS1PrivateKey, the output is indeed PKCS#1 data wrapped in a PKCS#8-style label. This causes the error to load the private key generated by trustauthority-cli. PKCS#1 should use Type: "RSA PRIVATE KEY" wheras PKCS#8 should use Type: "PRIVATE KEY". Align the header with the payload without changing the logic.