This repository was archived by the owner on Jul 25, 2019. It is now read-only.
Fix issue #68 remove unnecessary constructor calling#70
Open
tingshao wants to merge 1 commit intointel:masterfrom
Open
Fix issue #68 remove unnecessary constructor calling#70tingshao wants to merge 1 commit intointel:masterfrom
tingshao wants to merge 1 commit intointel:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@kenny-y please help to review this. Because it removes some code related to constructor calling which you added for another bug, I'm not a bit confident with the impact. Thanks.
when interface are defined as
[
Constructor(long val)
]
interface MyClass {
attribute readonly long value;
};
there will be compile error, because the generated nan__xxx file calls new MyClass() but there is no
default constructor for MyClass generated.